-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdl3-image] Add new port sdl3-image #42849
base: master
Are you sure you want to change the base?
Conversation
Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
"${CURRENT_PACKAGES_DIR}/debug/SDL3_image.framework" | ||
) | ||
|
||
file(INSTALL "${CMAKE_CURRENT_LIST_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary, you should remove this and your usage file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the usage file, I think that it is useful, but it needs to be redacted.
"${CURRENT_PACKAGES_DIR}/debug/SDL3_image.framework" | ||
) | ||
|
||
file(INSTALL "${CMAKE_CURRENT_LIST_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the usage file, I think that it is useful, but it needs to be redacted.
# this is heuristically generated, and may not be correct | ||
find_package(SDL3_image CONFIG REQUIRED) | ||
target_link_libraries(main PRIVATE CMath::CMath SDL3_image::SDL3_image-shared) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that reasonable usage would be like this:
# this is heuristically generated, and may not be correct | |
find_package(SDL3_image CONFIG REQUIRED) | |
target_link_libraries(main PRIVATE CMath::CMath SDL3_image::SDL3_image-shared) | |
find_package(SDL3_image CONFIG REQUIRED) | |
target_link_libraries(main PRIVATE $<IF:$<TARGET_EXISTS:SDL3_image::SDL3_image-shared>,SDL3_image::SDL3_image-shared,???????>) |
... with the appropriate target name for static builds in place of ????????.
sdl3-image provides pkg-config modules: | ||
|
||
# image loading library for Simple DirectMedia Layer | ||
sdl3-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lacking a line break at the end.
Add
SDL3-image
port. There already is anSDL3
port, but none for the relevant components (mixer, ttf, image). Used the latest 3.x release tag (preview-3.1.0
)find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.