[libsmb2] update to v6.2 and add features to activate krb5 #42779
+50
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
michael-doubez
changed the title
jimwang118
added
the
category:port-update
michael-doubez
force-pushed
the
libsmb2-update
branch
from
6d430eb to
f31932a
Compare
michael-doubez
changed the title
|
@jimwang118 Can you please review the PR ? |
|
All feature test passed with x64-windows triplet. |
dg0yt
reviewed
Dec 24, 2024
michael-doubez
force-pushed
the
libsmb2-update
branch
from
f31932a to
469ab41
Compare
|
@dg0yt krb5 transitive dependency added (thx for pointing that out) |
jimwang118
requested changes
Dec 25, 2024
Comment on lines
+18
to
+27
| "default-features": [ | ||
| { | ||
| "name": "gssapi", | ||
| "platform": "ios" | ||
| }, | ||
| { | ||
| "name": "krb5", | ||
| "platform": "linux" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Suggested change
| "default-features": [ | |
| { | |
| "name": "gssapi", | |
| "platform": "ios" | |
| }, | |
| { | |
| "name": "krb5", | |
| "platform": "linux" | |
| } | |
| ], | |
| "default-features": [ | |
| "gssapi", | |
| "krb5" | |
| ], |
jimwang118
removed
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.