Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtk,vtk-dicom,paraview] Fix/simplify python setup #42717

Merged
merged 6 commits into from
Jan 9, 2025
Merged

[vtk,vtk-dicom,paraview] Fix/simplify python setup #42717

merged 6 commits into from
Jan 9, 2025

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 15, 2024 •
edited
Loading

  • There is no VCPKG_EXECUTABLE_SUFFIX. According to the absolute path, this needs VCPKG_TARGET_EXECUTABLE_SUFFIX.
  • We don't need the minor version in order to name the python3 executable. (But python3 version numbers would be available from vcpkg-port-config.cmake.)
  • There are other licenses in share/vtk/licenses.

@dg0yt dg0yt marked this pull request as draft December 15, 2024 17:59
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 16, 2024
@dg0yt dg0yt marked this pull request as ready for review December 24, 2024 10:17
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jan 9, 2025
@JavierMatosD JavierMatosD merged commit 1420fe2 into microsoft:master Jan 9, 2025
17 checks passed
@dg0yt dg0yt deleted the vtk branch January 9, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @MonicaLiu0311 @JavierMatosD