Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] update to 1.87.0 #42678

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from
Draft

Conversation

miyanyan
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@miyanyan
Copy link
Contributor Author

there's no 1.87.0 release for boost-compatibility, so I keep it as 1.86.0

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Dec 13, 2024
@Cheney-W
Copy link
Contributor

Regarding the boost-build port, it requires manually updating the SHA512 value in the portfile.cmake.

@Cheney-W
Copy link
Contributor

Below ports should do the same thing as boost-build.

boost-graph-parallel
boost-mpi
boost-property-map-parallel

The line 31 of scripts/boost/generate-ports.ps1 should be removed.

@Cheney-W Cheney-W marked this pull request as draft December 13, 2024 09:44
@miyanyan
Copy link
Contributor Author

Below ports should do the same thing as boost-build.

boost-graph-parallel
boost-mpi
boost-property-map-parallel

The line 31 of scripts/boost/generate-ports.ps1 should be removed.

thanks

@miyanyan
Copy link
Contributor Author

@Cheney-W asio removed some deprecated facilities, see https://www.boost.org/doc/libs/1_87_0/doc/html/boost_asio/history.html, and this caused some ports build failed。

for https://github.com/glynos/cpp-netlib, it has been archived by the owner on Apr 3, 2020, should we still need to support it?

@@ -10,6 +10,9 @@ vcpkg_from_github(

set(FEATURE_OPTIONS "")
include("${CMAKE_CURRENT_LIST_DIR}/features.cmake")
if (VCPKG_LIBRARY_LINKAGE STREQUAL "static")
list(APPEND FEATURE_OPTIONS "-DBOOST_IOSTREAMS_ZSTD_TARGET=zstd::libzstd_static")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
list(APPEND FEATURE_OPTIONS "-DBOOST_IOSTREAMS_ZSTD_TARGET=zstd::libzstd_static")
list(APPEND FEATURE_OPTIONS "-DBOOST_IOSTREAMS_ZSTD_TARGET=zstd::libzstd")

if it is necessary at all. This target is always created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I changed to

if (BOOST_IOSTREAMS_ENABLE_ZSTD)
    list(APPEND FEATURE_OPTIONS "-DBOOST_IOSTREAMS_ZSTD_TARGET=zstd::libzstd")
endif()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt there's an error when vcpkg install avro-cpp:x64-windows-static:

CMake Error at D:/installed/x64-windows-static/share/boost_iostreams/boost_iostreams-targets.cmake:60 (set_target_properties):
  The link interface of target "Boost::iostreams" contains:

    zstd::libzstd

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  D:/installed/x64-windows-static/share/boost_iostreams/boost_iostreams-config.cmake:67 (include)
  D:/a/_work/1/s/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  D:/installed/x64-windows-static/share/boost/BoostConfig.cmake:67 (find_package)
  D:/installed/x64-windows-static/share/boost/BoostConfig.cmake:128 (boostcfg_find_component)
  D:/installed/x64-windows-static/share/boost/vcpkg-cmake-wrapper.cmake:3 (_find_package)
  D:/a/_work/1/s/scripts/buildsystems/vcpkg.cmake:813 (include)
  D:/downloads/tools/cmake-3.30.1-windows/cmake-3.30.1-windows-i386/share/cmake-3.30/Modules/FindBoost.cmake:610 (find_package)
  D:/installed/x64-windows-static/share/boost/vcpkg-cmake-wrapper.cmake:3 (_find_package)
  D:/a/_work/1/s/scripts/buildsystems/vcpkg.cmake:813 (include)
  CMakeLists.txt:77 (find_package)

config-x64-windows-static-out.log

but if I changed to

if (VCPKG_LIBRARY_LINKAGE STREQUAL "static")
    list(APPEND FEATURE_OPTIONS "-DBOOST_IOSTREAMS_ZSTD_TARGET=zstd::libzstd_static")
endif()

it works well, seems target zstd::libzstd not work when build static?
boost_iostreams-targets.txt
zstdTargets.txt

@Tradias
Copy link
Contributor

Tradias commented Dec 18, 2024

Consider removing supports limitations from Boost.Cobalt, see boostorg/cobalt#179 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants