Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencv4] Add include <chrono> for system_clock #42637

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Dec 11, 2024

An issue revealed in microsoft/STL#5105, that can be fixed by including <chrono>.

modules\gapi\src\streaming\gstreamer\gstreamersource.cpp(234): error C2039: 'system_clock': is not a member of 'std::chrono'

Submit upstream opencv/opencv#26668

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port feature opencv4[ade,calib3d,contrib,core,cuda,cudnn,default-features,dnn,dnn-cuda,dshow,eigen,ffmpeg,freetype,fs,gapi,gdcm,gstreamer,highgui,intrinsics,ipp,jasper,jpeg,nonfree,opencl,opengl,openjpeg,openmp,ovis,png,python,qt,quirc,sfm,tbb,thread,tiff,vtk,vulkan,webp,win32ui] installation tests pass with the triplet x64-windows.

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 11, 2024
@cenit
Copy link
Contributor

cenit commented Dec 14, 2024

i assume it is needed also for opencv3 and opencv2?

@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/opencv4/add-include-chrono branch from 9195a9c to fc39a4c Compare December 16, 2024 06:37
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/opencv4/add-include-chrono branch from fc39a4c to 2f81923 Compare December 24, 2024 07:02
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Dec 24, 2024

i assume it is needed also for opencv3 and opencv2?

It is not covered yet, but the upstream would synchronize these fixes after it merged.

@WangWeiLin-MV WangWeiLin-MV mentioned this pull request Dec 24, 2024
7 tasks
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Dec 25, 2024

Wait fix in #42912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants