Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wolfmqtt] update to 1.19.0 #38849

Merged
merged 5 commits into from
May 31, 2024
Merged

Conversation

lealem47
Copy link
Contributor

No description provided.

@lealem47
Copy link
Contributor Author

@microsoft-github-policy-service agree company="wolfSSL"

@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label May 22, 2024
ports/wolfmqtt/portfile.cmake Outdated Show resolved Hide resolved
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port usage tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label May 24, 2024
@BillyONeal
Copy link
Member

BillyONeal commented May 25, 2024

Can you explain why the CMake patch is no longer necessary (in order to force REQUIRED)? Thanks!

(I'm not saying that there's anything wrong with the change, I just want to make sure I understand why there is no problem should there be none :) )

@WangWeiLin-MV WangWeiLin-MV removed the info:reviewed Pull Request changes follow basic guidelines label May 27, 2024
@lealem47
Copy link
Contributor Author

Can you explain why the CMake patch is no longer necessary (in order to force REQUIRED)? Thanks!

(I'm not saying that there's anything wrong with the change, I just want to make sure I understand why there is no problem should there be none :) )

Hi @BillyONeal, The patch is no longer necessary because it is already included in latest versions of wolfMQTT

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label May 31, 2024
@vicroms vicroms merged commit 47364fb into microsoft:master May 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants