-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg_find_acquire_program(NINJA).cmake] Update to 1.12.0 #38538
Conversation
IMO it would be good to chose the arm variant on arm64 hosts now. 1.12.0 has arm64 binaries for linux and windows. Possible patterns (windows, linux): vcpkg/scripts/cmake/vcpkg_configure_meson.cmake Lines 124 to 137 in 815d93b
vcpkg/scripts/cmake/vcpkg_configure_meson.cmake Lines 147 to 160 in 815d93b
|
@microsoft-github-policy-service agree |
@dg0yt Hi, thanks for your suggestion. I have added arm64 binaries for linux and windows. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@xb284524239, Thanks for your PR, this is test error log, please take a look. |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
@JonLiu1993 The log file above is empty. |
@xb284524239, Sorry for my negligence, I have uploaded the latest log: |
Fixes microsoft#38494 Resurrects microsoft#38538 Co-authored-by: xb284524239 <[email protected]>
I'm sorry there was some confusion here. I'll make sure you're credited as a co-author when #39260 merges. Thanks for the submission! |
@BillyONeal Thanks, and I wish you success. |
* Update Ninja to 1.12. Fixes microsoft#38494 Resurrects microsoft#38538 Co-authored-by: xb284524239 <[email protected]> * 1.12.1 Also fix vcpkgTools.xml --------- Co-authored-by: Billy Robert O'Neal III <[email protected]> Co-authored-by: xb284524239 <[email protected]>
Fixes #38494