Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openssl] install cmake config wrapper only at the end #38398

Merged
merged 5 commits into from
May 13, 2024

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Apr 24, 2024

Fixes #37987

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

i don't know why adding the config wrapper at the beginning results in a missing file in the end, but at least in this way it works.

Could it be that including a portfile in a portfile triggers any cleanup in the packages folder?

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Apr 25, 2024
@WangWeiLin-MV
Copy link
Contributor

Note: I will be converting your PR to draft status. Please click "Ready for review" after making the fix and modifications.

@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft April 28, 2024 07:57
@Neumann-A
Copy link
Contributor

@WangWeiLin-MV: converting this to draft makes no sense.

@cenit
Copy link
Contributor Author

cenit commented Apr 29, 2024

which reviews?

@cenit cenit marked this pull request as ready for review April 29, 2024 10:20
@cenit
Copy link
Contributor Author

cenit commented Apr 29, 2024

i don't think any regression is due to this pr
nor i have time to make those fixes!

@cenit
Copy link
Contributor Author

cenit commented Apr 30, 2024

@BillyONeal it's more than one month that many ports (anything that depends on openssl) cannot be built on linux on many machines (e.g. any github action runner)

this pr fixes the symptom (but does not understand the real problem)

what shall we do to better expedite the merge of a fix?

@dg0yt
Copy link
Contributor

dg0yt commented Apr 30, 2024

@cenit Please do a git commit --allow-empty -m CI; git push to trigger CI.

@cenit
Copy link
Contributor Author

cenit commented May 2, 2024

kddockwidgets regression described here #38509 and independent from this PR

@cenit
Copy link
Contributor Author

cenit commented May 11, 2024

sorry can i ask what is blocking the merge of this PR? there are no regressions anymore after the last retrigger

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port usage tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label May 13, 2024
@data-queue data-queue merged commit ce2c1f0 into microsoft:master May 13, 2024
17 checks passed
@cenit cenit deleted the dev/cenit/openssl branch May 13, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libarchive] Build failure on x64-linux (static only)
5 participants