Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kddockwidgets] seems to have optional deps #38509

Open
Neumann-A opened this issue May 1, 2024 · 2 comments · May be fixed by #38611
Open

[kddockwidgets] seems to have optional deps #38509

Neumann-A opened this issue May 1, 2024 · 2 comments · May be fixed by #38611
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Neumann-A
Copy link
Contributor

DragController.cpp.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) class std::shared_ptr<class spdlog::logger> __cdecl spdlog::get(char const *)" (__imp_?get@spdlog@@YA?AV?$shared_ptr@Vlogger@spdlog@@@std@@PEBD@Z)
  Hint on symbols that are defined and could potentially match:
    "__declspec(dllimport) public: static class QQmlEnginePrivate * __cdecl QQmlEnginePrivate::get(class QQmlEngine *)" (__imp_?get@QQmlEnginePrivate@@SAPEAV1@PEAVQQmlEngine@@@Z)
    "__declspec(dllimport) public: static class QQuickItemPrivate * __cdecl QQuickItemPrivate::get(class QQuickItem *)" (__imp_?get@QQuickItemPrivate@@SAPEAV1@PEAVQQuickItem@@@Z)
    "__declspec(dllimport) public: static class QQuickItemPrivate const * __cdecl QQuickItemPrivate::get(class QQuickItem const *)" (__imp_?get@QQuickItemPrivate@@SAPEBV1@PEBVQQuickItem@@@Z)

bin\kddockwidgets-qt62d.dll : fatal error LNK1120: 1 unresolved externals

Seems to lookup qtdeclarative/qtquick but is only declaring a dependency on qtbase

@Neumann-A
Copy link
Contributor Author

Neumann-A commented May 1, 2024

@Neumann-A
Copy link
Contributor Author

Broken by #35882 removing -DKDDockWidgets_QTQUICK=OFF and not controlling KDDockWidgets_FRONTENDS explicitly (since that seems to be the new way to control it). @MonicaLiu0311 please fix your introduced regression

@JonLiu1993 JonLiu1993 self-assigned this May 6, 2024
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label May 6, 2024
@MonicaLiu0311 MonicaLiu0311 linked a pull request May 7, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants