Signature help implementation

internal/ast/utilities.go

@@ -2965,12 +2965,22 @@ func GetPropertyNameForPropertyNameNode(name *Node) string {
 	panic("Unhandled case in getPropertyNameForPropertyNameNode")
 }
 
-// !!!
 func HasQuestionToken(node *Node) bool {
 	switch node.Kind {
-	case KindParameter, KindMethodDeclaration, KindMethodSignature, KindShorthandPropertyAssignment,
-		KindPropertyAssignment, KindPropertyDeclaration, KindPropertySignature:
+	case KindParameter:
 		return node.AsParameterDeclaration().QuestionToken != nil
+	case KindMethodDeclaration:
+		return IsQuestionToken(node.AsMethodDeclaration().PostfixToken)
+	case KindShorthandPropertyAssignment:
+		return IsQuestionToken(node.AsShorthandPropertyAssignment().PostfixToken)
+	case KindMethodSignature:
+		return IsQuestionToken(node.AsMethodSignatureDeclaration().PostfixToken)
+	case KindPropertySignature:
+		return IsQuestionToken(node.AsPropertySignatureDeclaration().PostfixToken)
+	case KindPropertyAssignment:
+		return IsQuestionToken(node.AsPropertyAssignment().PostfixToken)
+	case KindPropertyDeclaration:
+		return IsQuestionToken(node.AsPropertyDeclaration().PostfixToken)
 	}
 	return false
 }

internal/ls/signaturehelp.go

@@ -356,7 +356,7 @@ func itemInfoForParameters(candidateSignature *checker.Signature, c *checker.Che
 	printer := printer.NewPrinter(printer.PrinterOptions{NewLine: core.NewLineKindLF}, printer.PrintHandlers{}, nil)
 
 	var getTypeParameters []signatureHelpParameter = []signatureHelpParameter{}
-	if candidateSignature.TypeParameters() != nil && len(candidateSignature.TypeParameters()) != 0 {
+	if len(candidateSignature.TypeParameters()) != 0 {
 		for _, typeParameter := range candidateSignature.TypeParameters() {
 			getTypeParameters = append(getTypeParameters, createSignatureHelpParameterForTypeParameter(typeParameter, sourceFile, enclosingDeclaratipn, c, printer))
 		}