Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuroSAT: use percentile normalization during plotting #2557

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Feb 3, 2025

Related to #1263

The current plotting method works great for our dataset, but fails as soon as normalization is added (e.g., via our data module). By using percentile normalization, both the dataset and data module should work.

P.S. We should do this for all datasets if anyone is ever bored and looking for an easy contribution. I only did EuroSAT because it's used throughout our tutorials.

@adamjstewart adamjstewart added this to the 0.6.3 milestone Feb 3, 2025
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Feb 3, 2025
@calebrob6
Copy link
Member

I don't think percentile normalization is a good way to get around whatever effects that the augmentations/normalization step adds. In some cases (e.g. I'm augmenting color or brightness) I'd like to be able to see differences between samples clearly. Having a reverse augmentation step is a better way to handle that case.

image = np.clip(image / 3000, 0, 1) produces very reasonable looking output that you can compare between images, why change this?

@adamjstewart
Copy link
Collaborator Author

I'm also fine with a reverse normalization in the trainer/task/module/thingy. I've never actually tried it before, how straightforward is it to use? Does it have issues with cropping? Let me see how much work this is to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants