Update InvokeTestingPlatformTask to prefer running Exe over dotnet exec dll
#5094
+102
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
requested review from
MarcoRossignoli and
Evangelink
as code owners
Youssef1313
commented
Feb 21, 2025
Comment on lines
+360
to
+370
| UseAppHost="$(UseAppHost)" | ||
| IsExecutable="$(_IsExecutable)" | ||
| TargetDir="$(TargetDir)" | ||
| AssemblyName="$(AssemblyName)" | ||
| NativeExecutableExtension="$(_NativeExecutableExtension)" |
There was a problem hiding this comment.
@baronfel Could you please confirm if it's okay to use _NativeExecutableExtension and _IsExecutable? We want to avoid using things that may potentially break in future.
There was a problem hiding this comment.
Both are set by the .NET SDK in props files and so should be available. They are _-prefixed properties, which means we don't like to encourage their direct use, but I don't think we make this data available in any other way at this time. cc @dsplaisted for heads-up that more folks are taking data dependencies on SDK-private members.
Evangelink
previously approved these changes
Feb 21, 2025
src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
Outdated
Show resolved
Hide resolved
nohwnd
reviewed
Feb 21, 2025
src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Evangelink
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually verified this works as expected. For microsoft/PowerToys#37001, tests run successfully when running the Exe directly but not when using
dotnet exec dll. I wasn't able to set up projects in a similar way as PowerToys to repro the issue and have a test. But I think it makes sense to run directly, and potentially even faster. We probably have enough tests to know if this change is problematic for a main stream scenario.