Use ReferenceTrimmer #5009
Open
Use ReferenceTrimmer #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
requested review from
MarcoRossignoli,
Youssef1313 and
Evangelink
as code owners
|
TODO: Review number of tests + content of nupkg FYI @Youssef1313 |
Youssef1313
reviewed
Feb 16, 2025
| @@ -19,8 +19,10 @@ | |||
| #if ENABLE_CODECOVERAGE | |||
| builder.AddCodeCoverageProvider(); | |||
| #endif | |||
| builder.AddCrashDumpProvider(); | |||
| builder.AddAppInsightsTelemetryProvider(); | |||
| builder.AddCrashDumpProvider(ignoreIfNotSupported: true); | |||
There was a problem hiding this comment.
I'm curious why ignoreIfNotSupported was not needed previously
Youssef1313
reviewed
Feb 16, 2025
| builder.AddHangDumpProvider(); | ||
| builder.AddRetryProvider(); |
There was a problem hiding this comment.
@Evangelink Do we want to use re-try for unit tests? I'm afraid this could hide race conditions and flaky tests that indicate real issues
Youssef1313
reviewed
Feb 16, 2025
| @@ -19,8 +19,10 @@ | |||
| #if ENABLE_CODECOVERAGE | |||
| builder.AddCodeCoverageProvider(); | |||
| #endif | |||
| builder.AddCrashDumpProvider(); | |||
| builder.AddAppInsightsTelemetryProvider(); | |||
There was a problem hiding this comment.
@Evangelink Any reason telemetry wasn't enabled previously? Is it intentional for our tests to opt-out for telemetry? It's already enabled for two other test projects
Youssef1313
reviewed
Feb 16, 2025
| @@ -20,14 +20,15 @@ | |||
| #if ENABLE_CODECOVERAGE | |||
| builder.AddCodeCoverageProvider(); | |||
| #endif | |||
| Console.WriteLine("NATIVE_AOT disabled"); | |||
Youssef1313
reviewed
Feb 16, 2025
| @@ -17,7 +17,7 @@ | |||
| <ItemGroup> | |||
| <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Platform\Microsoft.Testing.Platform.csproj" /> | |||
| <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport.Abstractions\Microsoft.Testing.Extensions.TrxReport.Abstractions.csproj" /> | |||
| <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Telemetry\Microsoft.Testing.Extensions.Telemetry.csproj" /> | |||
| <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Telemetry\Microsoft.Testing.Extensions.Telemetry.csproj" ReferenceOutputAssembly="false" /> | |||
There was a problem hiding this comment.
Does this affect the publicly visible dependencies of the VSTestBridge NuGet package?
Youssef1313
reviewed
Feb 16, 2025
| @@ -37,7 +37,6 @@ This package extends Microsoft Testing Platform to provide a crash dump function | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Platform\Microsoft.Testing.Platform.csproj" /> | |||
| <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport.Abstractions\Microsoft.Testing.Extensions.TrxReport.Abstractions.csproj" /> | |||
There was a problem hiding this comment.
Same here. Does this affect the publicly visible dependencies of CrashDump?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.