Allow action to run on other platforms #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action now check the path variable in other plaforms for msbuild and fail if it does not find it (or it is not of the correct version)
|
@microsoft-github-policy-service agree |
|
Thanks @MatteoH2O1999 for the PR! While msbuild responds on Ubuntu-hosted, it is actually not the MSBuild that is intended for this action (e.g., I believe that is still the Mono version). I'm going to hold on this one to discuss with some folks a bit as it might introduce some odd support aspects for us ;-). /cc @baronfel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow simpler workflow writing this allows to run the action on all platforms.
This checks if msbuild is already in path (for github-hosted Ubuntu and MacOS runners it is).
If it is and the version matches with the one specified (always if "latest") the action simply terminates and does nothing, otherwise it fails as before.
Behavior on Windows is not changed.
On a side note, I fixed a couple of Typescript and Eslint errors