Set default architecture of msbuild to x64 if running on 64bit machine

[rocklan]

This addresses #88.

The msbuild-architecture parameter defined in the yml no longer defaults to 'x86' and instead can be empty. If so, the typescript code now detects if the OS is 64bit (by using Os.arch() - https://nodejs.org/api/os.html#osarch), and if so sets the default architecture to x64 (or should it be amd64?).

It works on my 64 bit build machines, but I don't have any other architectures to test this on, but it should be perfectly fine and not have any issues whatsoever, right? Maybe it's worth tagging this as v2-beta or something and give people the opportunity to opt in for a while to make sure it's ok.

[timheuer]

Thanks @rocklan -- want to check with the MSBuild crew on ensuring this would result in all the right things on OSes.

[rocklan]

@microsoft-github-policy-service agree company="Rome2rio"

[rocklan]

Any update on this?

[rocklan]

sigh

[baronfel]

Oh yeah, this is perfectly fine to do 👍

[baronfel]

@timheuer very sorry for the long delay here - this is safe and can be merged at any time.

[rainersigwald]

I'm not sure this is safe -- there are definitely builds in the wild that work on 32-bit MSBuild and will fail on 64-bit MSBuild. As far as I know AzDO isn't changing the default for that reason.

It is completely reasonable, though! We should encourage folks to use 64-bit MSBuild since it's the default VS 2022+ experience (which is probably slowly fixing the bugs where a build requires 32-bit), and also . . . everything else is moving to 64-bit.

Maybe in a major version bump?