.Net: Expose any custom attributes on the underlying function method #8367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
anthonypuppo
commented
Aug 26, 2024
| @@ -281,6 +288,7 @@ ValueTask<FunctionResult> Function(Kernel kernel, KernelFunction function, Kerne | |||
| Function = Function, | |||
| Name = functionName!, | |||
| Description = method.GetCustomAttribute<DescriptionAttribute>(inherit: true)?.Description ?? "", | |||
| Attributes = [.. Attribute.GetCustomAttributes(method, inherit: true)], | |||
There was a problem hiding this comment.
This only extracts attributes off the method. Possibly fine for a first pass but there's potentially value in also grabbing attributes off the plugin itself, parameters, etc.
anthonypuppo
commented
Aug 26, 2024
| @@ -74,6 +77,18 @@ public string Description | |||
| init => this._description = value ?? string.Empty; | |||
| } | |||
|
|
|||
| /// <summary>Gets the attributes on the function.</summary> | |||
| /// <remarks>If the function has no attributes, the returned list will be empty.</remarks> | |||
| public IReadOnlyList<Attribute> Attributes | |||
There was a problem hiding this comment.
Would it not make more sense to just expose the raw MethodInfo instance, rather than just the attributes?
|
@anthonypuppo We're doing any EOY backlog and PR clean-up. I'm going to close this PR for now but we can reopen once we have our plans made for the next semester and we pickup issue #8366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Any custom attributes applied to the method wrapped as a
KernelFunctionshould be available on theMetadataproperty (e.g., in ASP.NET it's common to use theAuthorizeattribute for authorization scenarios, the same concept could be applied here and validated in a custom function filter).Fixes #8366.
Starting this out as a draft. If the idea/implementation looks good, I can refactor tests as needed.
Contribution Checklist