Fix day format in TimeSkill (#1466)

The TimeSkill class was using the wrong format specifier for the day of the month, resulting in a two-digit year instead. This commit changes the format from "DD" to "dd", which correctly outputs the day as a number from 01 to 31. This fixes a potential confusion and inconsistency in the output of the TimeSkill methods. Co-authored-by: Lee Miller <[email protected]>
microsoft · Jun 15, 2023 · e30229a · e30229a
1 parent fa8b8b7
commit e30229a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/dotnet/src/SemanticKernel.UnitTests/CoreSkills/TimeSkillTests.cs b/dotnet/src/SemanticKernel.UnitTests/CoreSkills/TimeSkillTests.cs
@@ -42,6 +42,16 @@ public void DaysAgo()
         Assert.Equal(expected.Year, returned.Year);
     }
 
+    [Fact]
+    public void Day()
+    {
+        string expected = DateTime.Now.ToString("dd", CultureInfo.CurrentCulture);
+        var skill = new TimeSkill();
+        string result = skill.Day();
+        Assert.Equal(expected, result);
+        Assert.True(int.TryParse(result, out _));
+    }
+
     [Fact]
     public void LastMatchingDayBadInput()
     {

diff --git a/dotnet/src/SemanticKernel/CoreSkills/TimeSkill.cs b/dotnet/src/SemanticKernel/CoreSkills/TimeSkill.cs
@@ -159,7 +159,7 @@ public string MonthNumber()
     public string Day()
     {
         // Example: 12
-        return DateTimeOffset.Now.ToString("DD", CultureInfo.CurrentCulture);
+        return DateTimeOffset.Now.ToString("dd", CultureInfo.CurrentCulture);
     }
 
     /// <summary>