Add support for Conan package to spdx file again #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanbrandenburg @pownkel Could you please review the PR? |
tarun06
force-pushed
the
Add-support-for-conan-to-spdx-file
branch
from
fa1302e
to
a10dc41
Compare
|
@sfoslund @ryanbrandenburg @pownkel Could you please review the PR? |
|
Hi @rmkanda, sure, taking a look now. Just a heads up, ryanbrandenburg, pownkel and sebasgomez238 do not work on this project anymore. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 69.66% 70.00% +0.33%
==========================================
Files 277 277
Lines 8629 8630 +1
Branches 1004 1004
==========================================
+ Hits 6011 6041 +30
+ Misses 2101 2071 -30
- Partials 517 518 +1 ☔ View full report in Codecov by Sentry. |
sfoslund
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sebasgomez238 As part of #436 , Some Conan changes were missed out and that is the reason, Conan package are not part of SPDX file. Adding Conan support to SPDX file again. Could you please review?