Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Serilog.ILogger with Microsoft.Extensions.Logging.ILogger<T> #467

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sebasgomez238
Copy link
Collaborator

No description provided.

@sebasgomez238 sebasgomez238 changed the title Users/segomez/logger refactor refactor: replace Serilog.ILogger with Microsoft.Extensions.Logging.ILogger<T> Dec 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (8d19e9f) 59.82% compared to head (69710da) 59.78%.

Files Patch % Lines
...icrosoft.Sbom.Api/Output/MetadataBuilderFactory.cs 0.00% 8 Missing ⚠️
...oft.Sbom.Api/Output/Telemetry/TelemetryRecorder.cs 42.85% 7 Missing and 1 partial ⚠️
...ft.Sbom.Api/Executors/LicenseInformationService.cs 0.00% 5 Missing ⚠️
src/Microsoft.Sbom.Api/Output/MetadataBuilder.cs 28.57% 5 Missing ⚠️
...Api/Workflows/SBOMParserBasedValidationWorkflow.cs 42.85% 4 Missing ⚠️
...Sbom.Api/Executors/ComponentDetectionBaseWalker.cs 25.00% 3 Missing ⚠️
...kageDetails/ComponentDetailsUtils/RubyGemsUtils.cs 50.00% 3 Missing ⚠️
...t.Sbom.Api/PackageDetails/PackageDetailsFactory.cs 0.00% 3 Missing ⚠️
...Providers/FilesProviders/FileToJsonProviderBase.cs 0.00% 3 Missing ⚠️
...osoft.Sbom.Api/Workflows/SBOMGenerationWorkflow.cs 72.72% 3 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   59.82%   59.78%   -0.04%     
==========================================
  Files         248      248              
  Lines        7561     7545      -16     
  Branches      901      899       -2     
==========================================
- Hits         4523     4511      -12     
+ Misses       2626     2622       -4     
  Partials      412      412              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants