[rush] Add a reset function to the pnpmfile to allow for clearing state #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william2958
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
changed the title
iclanton
approved these changes
May 13, 2024
common/changes/@microsoft/rush/will-pnpmfile-reset_2024-05-10-19-46.json
Outdated
Show resolved
Hide resolved
| @@ -40,7 +49,7 @@ function init(context: IPnpmfileContext | any): IPnpmfileContext { | |||
| if (!context.pnpmfileShimSettings) { | |||
| context.pnpmfileShimSettings = __non_webpack_require__('./pnpmfileSettings.json'); | |||
There was a problem hiding this comment.
Were the installs running in the same process? If not I don't see how there could be contamination of in-memory state, and if so, then we need to purge the require.cache entry corresponding to ./pnpmfileSettings.json to ensure that we get the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR fixes an issue where the PnpmfileShim carries cached state between subsequent subspace installs.
Currently if the project graph looks like this:
projectA depends on projectB
projectA -> subspaceA
projectB -> subspaceB
and you run
rush install -t projectA, rush will incorrectly run subspaceB's pnpmfile when installing for subspaceA.This fixes the issue by clearing the state in the pnpmfile.
Details
How it was tested
Impacted documentation