Try to move readPackage to worker thread #4695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
reviewed
May 14, 2024
| @@ -26,6 +27,33 @@ let semver: typeof TSemver | undefined; | |||
| // once so they aren't repeatedly required in the hook functions. | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| function init(context: IPnpmfileContext | any): IPnpmfileContext { | |||
|
|
|||
| if (isMainThread) { | |||
| const worker = new Worker(__filename); | |||
There was a problem hiding this comment.
Such a worker would go in a separate library whose job is to load and invoke .pnpmfile.cjs files for the purpose of transforming package.json files. The benefit of the worker is to provide an isolated execution environment (for running scripts authored by other parties) that can be cleaned up after the operation completes.
It shouldn't go in PnpmfileShim.ts because that file is (also) loaded by the generated .pnpmfile.cjs, which is a single-threaded and lightweight hook for PNPM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
How it was tested
Impacted documentation