Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] When using cobuilds, no-op operations should not be treated as uncacheable #4660

Merged
merged 41 commits into from
May 25, 2024
Merged

[rush] When using cobuilds, no-op operations should not be treated as uncacheable #4660

merged 41 commits into from
May 25, 2024

Commits on May 10, 2024

  1. fix cobuild plugin sandbox

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    84bcc6d View commit details
    Browse the repository at this point in the history

  2. improve cache disabled check for skipped scripts

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e5780f4 View commit details
    Browse the repository at this point in the history

  3. add changeset

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f4b765a View commit details
    Browse the repository at this point in the history

  4. use itsnoop and adjust tests

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    22fd9cf View commit details
    Browse the repository at this point in the history

  5. small improvements in logging

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d7eb323 View commit details
    Browse the repository at this point in the history

  6. fix tsc

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9ca4353 View commit details
    Browse the repository at this point in the history

  7. better handling of noop and skipped elements

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    29cb7dc View commit details
    Browse the repository at this point in the history

  8. update to debug logs

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7e37a16 View commit details
    Browse the repository at this point in the history

  9. add logging about tree depth

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f39d8f8 View commit details
    Browse the repository at this point in the history

  10. adjust maxWidth and depth calcs

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e73fdba View commit details
    Browse the repository at this point in the history

  11. update wording for parents vs dependents

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b068fe8 View commit details
    Browse the repository at this point in the history

  12. operation depth wording

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6dd1b75 View commit details
    Browse the repository at this point in the history

  13. fix initial width calc

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9aa5a49 View commit details
    Browse the repository at this point in the history

  14. fix tsc errors

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5397768 View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: David Michon <[email protected]>
    @aramissennyeydd @dmichon-msft
    aramissennyeydd and dmichon-msft committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1244ea1 View commit details
    Browse the repository at this point in the history

  16. address PR comments

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d831692 View commit details
    Browse the repository at this point in the history

  17. move to a separate logging plugin and add tests

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ef71ebc View commit details
    Browse the repository at this point in the history

  18. fix linting errors

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    067b60b View commit details
    Browse the repository at this point in the history

  19. fix typing issue

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cdf753e View commit details
    Browse the repository at this point in the history

  20. retry tests

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    138c9e1 View commit details
    Browse the repository at this point in the history

  21. more linting

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    81f3536 View commit details
    Browse the repository at this point in the history

  22. Apply suggestions from code review 

    Co-authored-by: Ian Clanton-Thuon <[email protected]>
    @aramissennyeydd @iclanton
    aramissennyeydd and iclanton committed May 10, 2024
    Configuration menu
    Copy the full SHA
    98a2b91 View commit details
    Browse the repository at this point in the history

  23. make into a non-breaking change

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d98fd22 View commit details
    Browse the repository at this point in the history

  24. fix snapshots

    @aramissennyeydd
    aramissennyeydd committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3ecc6cc View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. fix clustering in the display plugin

    @aramissennyeydd
    aramissennyeydd committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6865a11 View commit details
    Browse the repository at this point in the history

  2. fix linting

    @aramissennyeydd
    aramissennyeydd committed May 22, 2024
    Configuration menu
    Copy the full SHA
    21ee0d6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Ian Clanton-Thuon <[email protected]>
    @aramissennyeydd @iclanton
    aramissennyeydd and iclanton committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0167239 View commit details
    Browse the repository at this point in the history

  2. make isNoOp an operation property and adjust cacheDisabled API

    @aramissennyeydd
    aramissennyeydd committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a7cd9e7 View commit details
    Browse the repository at this point in the history

  3. adjust following PR review

    @aramissennyeydd
    aramissennyeydd committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b693a40 View commit details
    Browse the repository at this point in the history

  4. adjust snapshots

    @aramissennyeydd
    aramissennyeydd committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f827bba View commit details
    Browse the repository at this point in the history

  5. adjust comments

    @aramissennyeydd
    aramissennyeydd committed May 23, 2024
    Configuration menu
    Copy the full SHA
    77bdaa0 View commit details
    Browse the repository at this point in the history

  6. address pr feedback for test

    @aramissennyeydd
    aramissennyeydd committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c19bcf3 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Ian Clanton-Thuon <[email protected]>
    @aramissennyeydd @iclanton
    aramissennyeydd and iclanton committed May 25, 2024
    Configuration menu
    Copy the full SHA
    5f6853f View commit details
    Browse the repository at this point in the history

  2. test fixes from PR review

    @aramissennyeydd
    aramissennyeydd committed May 25, 2024
    Configuration menu
    Copy the full SHA
    f0af2ff View commit details
    Browse the repository at this point in the history

  3. fix linting

    @aramissennyeydd
    aramissennyeydd committed May 25, 2024
    Configuration menu
    Copy the full SHA
    5e7da2c View commit details
    Browse the repository at this point in the history

  4. Update libraries/rush-lib/src/logic/operations/test/BuildPlanPlugin.t… 

    …est.ts

Co-authored-by: Ian Clanton-Thuon <[email protected]>
    @aramissennyeydd @iclanton
    aramissennyeydd and iclanton committed May 25, 2024
    Configuration menu
    Copy the full SHA
    fd3ea2b View commit details
    Browse the repository at this point in the history

  5. fix snapshots

    @aramissennyeydd
    aramissennyeydd committed May 25, 2024
    Configuration menu
    Copy the full SHA
    4c3b9de View commit details
    Browse the repository at this point in the history

  6. Update libraries/rush-lib/src/logic/operations/test/BuildPlanPlugin.t… 

    …est.ts

Co-authored-by: Ian Clanton-Thuon <[email protected]>
    @aramissennyeydd @iclanton
    aramissennyeydd and iclanton committed May 25, 2024
    Configuration menu
    Copy the full SHA
    1ca4ca1 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into fix-caching-behavio… 

    …r-undefined
    @aramissennyeydd
    aramissennyeydd committed May 25, 2024
    Configuration menu
    Copy the full SHA
    0b05318 View commit details
    Browse the repository at this point in the history

  8. udpate snapshot

    @aramissennyeydd
    aramissennyeydd committed May 25, 2024
    Configuration menu
    Copy the full SHA
    fd1e8f5 View commit details
    Browse the repository at this point in the history

  9. Fix an issue with StringBufferTerminalProvider's 'normalizeSpecialCha… 

    …racters' option.
    @iclanton
    iclanton committed May 25, 2024
    Configuration menu
    Copy the full SHA
    ffb6427 View commit details
    Browse the repository at this point in the history