[rush-build-graph-plugin] Add plugin for generating a build graph file for the given command #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPapp-MS
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
iclanton
reviewed
Apr 8, 2024
rush-plugins/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/.gitattributes
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/.gitignore
Outdated
Show resolved
Hide resolved
...ins/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/common/config/rush/pnpm-config.json
Outdated
Show resolved
Hide resolved
...gins/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/common/config/rush/repo-state.json
Outdated
Show resolved
Hide resolved
dmichon-msft
reviewed
Apr 9, 2024
...ns/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/common/config/rush/command-line.json
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/graph.json
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/test/GraphParser.test.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/test/GraphParser.test.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/test/GraphParser.test.ts
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Apr 9, 2024
common/changes/@microsoft/rush/user-bpapp-ms-add-graph-plugin_2024-04-08-23-25.json
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Apr 9, 2024
rush-plugins/rush-build-graph-plugin/rushBuildGraphPluginTestRepo/graph.json
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/DropBuildGraphPlugin.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/DropBuildGraphPlugin.ts
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/examples/debug-graph.json
Outdated
Show resolved
Hide resolved
rush-plugins/rush-build-graph-plugin/src/test/GraphParser.test.ts
Outdated
Show resolved
Hide resolved
|
Make sure you include a |
BPapp-MS
force-pushed
the
user/bpapp-ms/add-graph-plugin
branch
from
562ad40
to
43aecc9
Compare
Co-authored-by: David Michon <[email protected]>
…2024-04-08-23-25.json Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: David Michon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: David Michon <[email protected]>
BPapp-MS
force-pushed
the
user/bpapp-ms/add-graph-plugin
branch
from
522c46b
to
0fa80ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are working with BuildXL to hand Rush's build graph to their build orchestrator, in order to vastly simplify and future-proof the interface between the two.
Details
This plugin runs when a rush command is run with the option
--drop-graph FILE_PATH. It taps into the createOperations hook, extracts the necessary info from the graph that it's handed, removes empty commands and forwards their dependencies, validates the resulting graph, drops it as json to the provided FILE_PATH, and exits.How it was tested
A test repo was created for running the plugin. The graph resulting from running on that repo is saved to a file where unit tests are run against it.
Impacted documentation
Docs should be created on the website only after this plugin is solidified and compatible with BuildXL.