chore(ebpf): update bpf header files #1928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
force-pushed
the
nddq/bpfHeaders
branch
2 times, most recently
from
ecc0cac to
604acb8
Compare
timraymond
reviewed
Nov 12, 2025
Member
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
I'm going to assume that the Makefile and the Dockerfiles should be the prime focus of reviews here... and the others are just generated from those. Is that right, or is there anything else that should have eyes on it?
|
Any updates on this PR? |
This patch updates the bpf header files, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfile for building the agent and generating Go codes. Signed-off-by: Quang Nguyen <[email protected]>
SRodi
reviewed
Dec 19, 2025
| #endif | ||
| } | ||
|
|
||
| #ifdef ADVANCED_METRICS |
| SEC("fexit/nf_hook_slow") | ||
| int BPF_PROG(nf_hook_slow_fexit, struct sk_buff *skb, struct nf_hook_state *state, | ||
| const struct nf_hook_entries *e, unsigned int s, int retVal) | ||
| int BPF_PROG(nf_hook_slow_fexit, struct sk_buff *skb, struct nf_hook_state *state, int retVal) |
Member
There was a problem hiding this comment.
Is this the only change in args across all BPF programs? Can you show a screenshot of all programs compiling correctly after this change? It might be good to have a validation target included in the Makefile.
SRodi
reviewed
Dec 19, 2025
Member
There was a problem hiding this comment.
the massive update to vmlinux.h is not strictly required if we move to runtime generation. I think we should look into #1777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the bpf header files from upstream libbpf, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfiles for building the agent and generating Go codes.
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.