Skip to content

fix: change mounting path in retina-agent from /var/run to /var/run/cilium #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

fix: change mounting path in retina-agent from /var/run to /var/run/cilium #1389

merged 2 commits into from
Mar 14, 2025

Conversation

alexcastilio
Copy link
Contributor

@alexcastilio alexcastilio commented Feb 26, 2025 •
edited
Loading

Description

Changes:

  • Change mounting path in retina-agent from /var/run to /var/run/cilium
  • Hard-code volumes and volumeMounts in agent's yaml file. This does not need to be configurable through helm chart values.yaml file
  • Remove volumeMounts from helm chart values.yaml file

Related Issue

#1386

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Flows:
image

Additional Notes

Add any additional notes or context about the pull request here.

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@alexcastilio alexcastilio requested a review from a team as a code owner February 26, 2025 13:54
anubhabMajumdar
anubhabMajumdar reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test results?

  • Is Hubble control plane working with these changes?
  • Can you see flows served on unix:///var/run/cilium/hubble.sock ?

@alexcastilio alexcastilio force-pushed the alexcastilio/mounting-path branch from c5f995b to 82370c4 Compare February 27, 2025 16:41
@alexcastilio
Copy link
Contributor Author

alexcastilio commented Feb 27, 2025 •
edited
Loading

Can you add test results?

  • Is Hubble control plane working with these changes?
  • Can you see flows served on unix:///var/run/cilium/hubble.sock ?

@anubhabMajumdar I added an image of flows that I had forgotten before. Is that enough or is there any further detail that you want to check?

@anubhabMajumdar
Copy link
Contributor

Can you add test results?

  • Is Hubble control plane working with these changes?
  • Can you see flows served on unix:///var/run/cilium/hubble.sock ?

@anubhabMajumdar I added an image of flows that I had forgotten before. Is that enough or is there any further detail that you want to check?

You can try k exec -it ds/retina-agent -- hubble observe flows.

@alexcastilio alexcastilio force-pushed the alexcastilio/mounting-path branch from 82370c4 to 98bcbb7 Compare March 4, 2025 11:50
@alexcastilio
Copy link
Contributor Author

Can you add test results?

  • Is Hubble control plane working with these changes?
  • Can you see flows served on unix:///var/run/cilium/hubble.sock ?

@anubhabMajumdar I added an image of flows that I had forgotten before. Is that enough or is there any further detail that you want to check?

You can try k exec -it ds/retina-agent -- hubble observe flows.
image

@alexcastilio alexcastilio force-pushed the alexcastilio/mounting-path branch 2 times, most recently from 043cd54 to 4d02dc7 Compare March 4, 2025 16:18
@alexcastilio alexcastilio force-pushed the alexcastilio/mounting-path branch 2 times, most recently from ec0e2a4 to 888b004 Compare March 4, 2025 16:37
@alexcastilio
fix(hubble-chart): volumeMount handling
2b89d7b 
Signed-off-by: Alex Castilio dos Santos <[email protected]>
@alexcastilio alexcastilio force-pushed the alexcastilio/mounting-path branch from 888b004 to 2b89d7b Compare March 13, 2025 17:14
@anubhabMajumdar anubhabMajumdar self-requested a review March 13, 2025 17:47
@alexcastilio
Copy link
Contributor Author

Test after latest changes:
image

@alexcastilio alexcastilio added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 579105e Mar 14, 2025
29 checks passed
@alexcastilio alexcastilio deleted the alexcastilio/mounting-path branch March 14, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeZappa87 MikeZappa87 MikeZappa87 left review comments

@ibezrukavyi ibezrukavyi Awaiting requested review from ibezrukavyi

@anubhabMajumdar anubhabMajumdar Awaiting requested review from anubhabMajumdar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcastilio @anubhabMajumdar @MikeZappa87