Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validKeysDown, validKeysUp, passThroughAllKeyEvents #1615

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 3, 2023

Note: Don't merge until #2171 has landed, and ensure this makes it RNM version 0.75. Then we can rebase this PR and remove the first commit (basically a local cherry-pick of #2171)

Summary:

Followup to #2171 , remove the JS and native handling for validKeysDown, validKeysUp, and passThroughAllKeyEvents. On the native side, rework the native handling to take the props keyDownEvents and keyUpEvents instead.

Test Plan:

Updated the RNTester example.

@pull-bot
Copy link

pull-bot commented Jan 3, 2023

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 09137a9

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Fails
🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️

Libraries/NativeComponent/BaseViewConfig.macos.js#L13 - Libraries/NativeComponent/BaseViewConfig.macos.js line 13 – Requires should be sorted alphabetically (lint/sort-imports)

Generated by 🚫 dangerJS against dfa985d

@Saadnajmi Saadnajmi changed the title [Draft] Add support for keyDownEvents and keyUpEvents Remove validKeysDown, validKeysUp, passThroughAllKeyEvents Aug 22, 2024
@Saadnajmi Saadnajmi marked this pull request as ready for review August 22, 2024 07:59
@Saadnajmi Saadnajmi requested a review from a team as a code owner August 22, 2024 07:59
@Saadnajmi Saadnajmi force-pushed the keyDownEvents branch 4 times, most recently from 769b048 to 38371f2 Compare August 23, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants