You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Don't merge until #2171 has landed, and ensure this makes it RNM version 0.75. Then we can rebase this PR and remove the first commit (basically a local cherry-pick of #2171)
Summary:
Followup to #2171 , remove the JS and native handling for validKeysDown, validKeysUp, and passThroughAllKeyEvents. On the native side, rework the native handling to take the props keyDownEvents and keyUpEvents instead.
📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
CATEGORY may be:
General
macOS
iOS
Android
JavaScript
Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
Added, for new features.
Changed, for changes in existing functionality.
Deprecated, for soon-to-be removed features.
Removed, for now removed features.
Fixed, for any bug fixes.
Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️
Libraries/NativeComponent/BaseViewConfig.macos.js#L13 - Libraries/NativeComponent/BaseViewConfig.macos.js line 13 – Requires should be sorted alphabetically (lint/sort-imports)
Saadnajmi
changed the title
[Draft] Add support for keyDownEvents and keyUpEvents
Remove validKeysDown, validKeysUp, passThroughAllKeyEventsAug 22, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Don't merge until #2171 has landed, and ensure this makes it RNM version 0.75. Then we can rebase this PR and remove the first commit (basically a local cherry-pick of #2171)
Summary:
Followup to #2171 , remove the JS and native handling for
validKeysDown
,validKeysUp
, andpassThroughAllKeyEvents
. On the native side, rework the native handling to take the propskeyDownEvents
andkeyUpEvents
instead.Test Plan:
Updated the RNTester example.