Fix include error span #2444
Closed
Fix include error span #2444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
Replaces #2444 - **Unified project loading**: Consolidated OpenQASM project loading across all components (compiler, language service, Python pip, WASM) to use a single `load_openqasm_project` method instead of multiple inconsistent approaches - **Improved error handling**: Enhanced include file error propagation by properly associating errors with their source spans and include statements in the parent file - **Better error reporting**: Include file errors now display with proper source location information, showing the problematic include statement in context instead of generic "Not Found" messages - **API simplification**: - Removed custom `ImportResolver` from Python interop in favor of unified project loading - Replaced multiple `compile_to_qsharp_ast_with_config` calls with `parse_and_compile_to_qsharp_ast_with_config`. With parsing, compilation, and project loading being separated, trying to clear up intent and purpose. - Added `parse_sources` utility function for handling multiple source files - **Enhanced debugging support**: Added test coverage for setting breakpoints in multi-file OpenQASM programs with included files - **Code structure improvements**: - Added `Debug` and `Clone` derives to semantic analysis types for better tooling support - Consolidated error handling logic into reusable helper functions - Improved span tracking for IO errors through the compilation pipeline The changes ensure consistent OpenQASM project handling across VS Code extension, Python package, WASM builds, and language service while providing better error messages and debugging capabilities for multi-file projects.
|
Superseded by #2512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include error spans were set to the beginning of the file, since include errors were being pushed in resolution, where there is no knowledge of spans. This PR delays pushing
IOerrors until lowering, so that we can construct the error with the correct span.