Terminate TOC recursion on full filepath match #10353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganicke
changed the title
|
Thanks so much @ganicke. We will review this today. |
riknoll
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TOC/breadcrumb match is relying on an
indexOf() == 0check instead of a full string match. Therefore a path string ofcode-eval-toolwill match both of the TOC entries forcode-eval-toolandcodewith a recursive TOC lookup. This will render an aggregated breadcrumb of both the TOC entries.Note: The fix included here is a suggestion for a full path match. You can offer better or more efficient check.
Closes microsoft/pxt-microbit#6069