Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code eval tool: use toast upon deletion instead of alert #10165

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open
Prev Previous commit
Next Next commit
renamed readd to reAdd
srietkerk committed Sep 10, 2024
commit 0935b2078b5bca70f6644e91a8a9d723c45bac00
4 changes: 2 additions & 2 deletions teachertool/src/components/CriteriaResultEntry.tsx
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ import { Button } from "react-common/components/controls/Button";
import { setEvalResult } from "../transforms/setEvalResult";
import { showToast } from "../transforms/showToast";
import { makeToast } from "../utils";
import { readdCriteriaToChecklist } from "../transforms/readdCriteriaToChecklist";
import { reAddCriteriaToChecklist } from "../transforms/reAddCriteriaToChecklist";
import { dismissToast } from "../state/actions";
import { softDeleteCriteriaFromChecklist } from "../transforms/softDeleteCriteriaFromChecklist";

@@ -82,7 +82,7 @@ const CriteriaResultError: React.FC<CriteriaResultErrorProps> = ({ criteriaInsta
const UndoDeleteCriteriaButton: React.FC<{ criteriaId: string, toastId: string }> = ({ criteriaId, toastId }) => {
const { dispatch } = useContext(AppStateContext);
const handleUndoClicked = () => {
readdCriteriaToChecklist(criteriaId);
reAddCriteriaToChecklist(criteriaId);
if (toastId) {
dispatch(dismissToast(toastId));
}
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import { setChecklist } from "./setChecklist";
import { Ticks } from "../constants";
import { getCriteriaInstanceWithId } from "../state/helpers";

export function readdCriteriaToChecklist(criteriaInstanceId: string) {
export function reAddCriteriaToChecklist(criteriaInstanceId: string) {
const { state: teacherTool } = stateAndDispatch();

logDebug(`Re-adding criteria with id: ${criteriaInstanceId}`);