Skip to content

Extension: add BP Lab #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Extension: add BP Lab #6121

merged 1 commit into from
Mar 20, 2025

Conversation

martinwork
Copy link
Contributor

@martinwork
Copy link
Contributor Author

@abchatra The servo blocks cause the simulator to jump down, but no simulated servo is shown. Can this be improved? Either to show the simulated servo, or stop the simulator moving?

@abchatra This extension's code is based on other extensions with MIT License. Is a link to the original in the docs enough to satisfy the MIT license condition?
"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

The originals are acknowledged in the docs, like this
https://github.com/team-bp/pxt-bplab/blob/96dc83f09f4f315f440c68981c6f932e7e502a1f/docs/ultrasonic-README.md?plain=1#L9
https://github.com/team-bp/pxt-bplab/blob/master/docs/ultrasonic-README.md

List of original extensions:
https://github.com/tinkertanker/pxt-iot-environment-kit
https://github.com/makecode-extensions/i2cLCD1602
https://github.com/tinkertanker/pxt-continuous-servo
https://github.com/makecode-extensions/TM1637
https://github.com/microsoft/pxt-sonar

@bplab-dev The link here is broken
https://github.com/team-bp/pxt-bplab/blob/96dc83f09f4f315f440c68981c6f932e7e502a1f/docs/seven-segment-README.md?plain=1#L9

@i33W
Copy link

i33W commented Mar 18, 2025

Thank you for your feedback, I checked the broken link in the seven-segment-README.md file you mentioned.
This link has been fixed at 28c589fabf7f7f7f39a2a80644b86f836a919cf67f, and now it will be linked to the correct address.
Thank you for your quick feedback.

@abchatra
Copy link
Collaborator

@martinwork please file a separate issue with a small repro if you can.

@abchatra This extension's code is based on other extensions with MIT License. Is a link to the original in the docs enough to satisfy the MIT license condition?
"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

This repo is MIT licensed, and original repo is also Microsoft repo with MIT license. We are good with this.

@abchatra abchatra merged commit b10702e into microsoft:master Mar 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants