Update visual plugin template to support TS strict mode (#74)

microsoft · May 3, 2023 · 402a304 · 402a304
1 parent a14c3c4
commit 402a304
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,10 @@
 
 This page contains information about changes to the **PowerBI-visuals-webpack-plugin**.
 
+## 3.2.1
+
+* update visual plugin template to support TS strict mode 
+
 ## 3.2.0
 * Fixed broken minification in pbiviz.json
 * Updated packages

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-webpack-plugin",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "PowerBI Custom Visuals webpack plugin",
   "main": "index.js",
   "keywords": [

diff --git a/templates/plugin-template.js b/templates/plugin-template.js
@@ -19,7 +19,7 @@ var ${pluginOptions.pluginName}: IVisualPlugin = {
     displayName: '${pluginOptions.visualDisplayName}',
     class: '${pluginOptions.visualClass}',
     apiVersion: '${pluginOptions.apiVersion}',
-    create: (options: VisualConstructorOptions) => {
+    create: (options?: VisualConstructorOptions) => {
         if (${pluginOptions.visualClass}) {
             return new ${pluginOptions.visualClass}(options);
         }
@@ -28,7 +28,7 @@ var ${pluginOptions.pluginName}: IVisualPlugin = {
     ${
 		compareVersions.compare(pluginOptions.apiVersion, "3.8.0", ">=")
 			? `createModalDialog: (dialogId: string, options: DialogConstructorOptions, initialState: object) => {
-        const dialogRegistry = globalThis.dialogRegistry;
+        const dialogRegistry = (<any>globalThis).dialogRegistry;
         if (dialogId in dialogRegistry) {
             new dialogRegistry[dialogId](options, initialState);
         }