Skip to content

fix(ui): Wait with polling if test is still scheduled #38656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpAdm wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(ui): Wait with polling if test is still scheduled #38656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/trace-viewer/src/ui/uiModeTraceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const TraceView: React.FC<{
clearTimeout(pollTimer.current);

const result = item.testCase?.results[0];
if (!result) {
if (!result || item.treeItem?.status === 'scheduled') {
Copy link
Member

@pavelfeldman pavelfeldman Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we have a test result for something that has not run yet?

setModel(undefined);
return;
}
Expand Down
5 changes: 5 additions & 0 deletions tests/playwright-test/ui-mode-test-run.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ test('should run on double click', async ({ runUITest }) => {
- button "Watch"
- treeitem "[icon-circle-outline] fails"
`);

const allMessages = await page.consoleMessages();
const messages = allMessages.filter(m => !m.location().url.includes('trace/sha1/src'));
expect(messages).toHaveLength(0);
expect(await page.pageErrors()).toHaveLength(0);
});

test('should run on Enter', async ({ runUITest }) => {
Expand Down