Skip to content

fix(trace-viewer): Keep showing source when test is scheduled #38364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix(trace-viewer): Keep showing source when test is scheduled #38364

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
937ec21
fix(trace-viewer): Keep showing source when test is scheduled
cpAdm Nov 29, 2025
c816b75
fix(trace-viewer): Handle fallback source location for SW 500 error c…
cpAdm Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/trace-viewer/src/ui/uiModeTraceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const TraceView: React.FC<{
return;
}

if (!outputDir) {
if (!outputDir || item.treeItem?.status === 'scheduled') {
Copy link
Member

@pavelfeldman pavelfeldman Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the present implementation, I don't see how this effect re-triggers and sets up the polling:
outputDir, item, setModel, counter, setCounter, pathSeparator - they all seem to be static.

From your comment, it seems like the issue is due to "Since there now is a model, useSources will instead try to fetch the source file from sha1/src, but with an empty trace URL.". We should handle it and still be able to return the fallback location.

Copy link
Contributor Author

@cpAdm cpAdm Nov 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item is in fact not static. It gets (indirectly) updated via sortAndPropagateStatus on testTree:

playwright/packages/trace-viewer/src/ui/uiModeView.tsx

Line 254 in 3a5a32d

testTree.sortAndPropagateStatus();

But maybe we should not rely on this implicit prop change?

For now I changed useSources to also refetch on 500 error code.

I am just not quite satisfied with all the console/SW errors that occur during any test. Notice the workIndex of -1 in /contexts fetches - which I tried avoid making by looking at item.treeItem?.status

image

setModel(undefined);
return;
}
Expand Down