feat(test-server): add acceptSnapshots API endpoint #38326
+100
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add server-side API to copy actual snapshots to expected locations: - Add acceptSnapshots() to TestServerInterface - Implement handler in TestServerDispatcher - Add connection method in TestServerConnection - Add test coverage for the API This is a backend-only change that adds the infrastructure for accepting snapshot updates. No UI changes included.
|
|
||
| async ping() {} | ||
|
|
||
| async acceptSnapshots(params: Parameters<TestServerInterface['acceptSnapshots']>[0]): ReturnType<TestServerInterface['acceptSnapshots']> { |
Member
There was a problem hiding this comment.
This is really a copyFile rather than accept snapshot endpoint. If we have it in this shape, we need to add some security considerations to prevent data loss and misuse.
Btw, do you know that there is a checkbox setting in the sidebar that allows accepting changed the snapshots on the test runs? Why not to just run it and then explore the diffs?
Author
There was a problem hiding this comment.
Thanks for the feedback and the pointer, I'll have to explore that. From your description it sounds like it accepts all changed snapshots on a run, but if the run is restricted to a subset of tests it might be functionally equivalent to what I'm trying to do. Let me get back to you with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add server-side API to accept snapshot updates by copying actual snapshots to expected locations:
acceptSnapshots()method toTestServerInterfaceTestServerDispatcherthat copies files and creates destination directoriesTestServerConnectionThis is a backend-only change that adds the infrastructure for accepting snapshot updates. No UI changes included.
Context
Split out from #38321 per reviewer feedback requesting smaller, incremental changes.
This PR contains only the backend API. Frontend changes will follow in a separate PR once this is merged.