Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-mode): prevent websocket connection leaks on reload #33643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui-mode): prevent websocket connection leaks on reload #33643

wants to merge 1 commit into from
+28 −2

Conversation

ruifigueira
Copy link
Contributor

Fixes: #33641

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node18

36917 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@ruifigueira
Copy link
Contributor Author

Failing on embedded-trace-viewer tests, that must be karma 😞 But apparently they have been failing for a couple of days, so it seems unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: WebSocket leakage in UI Mode
1 participant
@ruifigueira