Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not send favicon request to network when interception is on #33639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Nov 16, 2024

Otherwise we hit the network in presumably hermetic tests:

Error: 6 [ERROR] com.microsoft.playwright.TestBrowserContextStorageState.shouldCaptureLocalStorage -- Time elapsed: 7.768 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <{"cookies":[],"origins":[{"origin":"https://www.domain.com/","localStorage":[{"name":"name2","value":"value2"}]},{"origin":"https://www.example.com/","localStorage":[{"name":"name1","value":"value1"}]}]}> but was: <{"cookies":[{"name":"__cf_bm","value":"swy7AlkQNfUppNapX0xrvlt.YyuGQW91vnBWHolxA0Q-1731700690-1.0.1.1-hs3s0FARyESNGlio6FS9qbG3pDn9jeZIk0IpGBRkgPDDb5HDF7d6Vizjtfo52QDEeE85uhjBVIJvNtjV3q4XpQ","domain":".domain.com","path":"/","expires":1731702490.484379,"httpOnly":true,"secure":true,"sameSite":"None"}],"origins":[{"origin":"https://www.domain.com/","localStorage":[{"name":"name2","value":"value2"}]},{"origin":"https://www.example.com/","localStorage":[{"name":"name1","value":"value1"}]}]}>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at com.microsoft.playwright.Utils.assertJsonEquals(Utils.java:66)
	at com.microsoft.playwright.TestBrowserContextStorageState.shouldCaptureLocalStorage(TestBrowserContextStorageState.java:46)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)

Copy link
Contributor

Test results for "tests 1"

3 flaky ⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies @webkit-ubuntu-22.04-node18

36922 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant