Fix perfview handling of events reporting dynamic helpers #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic helpers are reported with MethodFlags.JitHelper. Events with this flag were ignored by PerfView before this change.
brianrob
reviewed
Jul 18, 2023
Comment on lines
+1427
to
+1430
| case BasicType.btChar16: | ||
| return "char16_t"; | ||
| case BasicType.btChar32: | ||
| return "char32_t"; |
There was a problem hiding this comment.
Is this a separate fix, or is this related to the jit helpers? I would expect it to be a separate fix.
There was a problem hiding this comment.
I am actually not sure; I've made this change couple of months ago to address my immediate need and forgotten about it. It is possible that this was a separate thing. I am going to test it locally with a dump from @TIHan, so I'll see.
There was a problem hiding this comment.
Sounds good. Thanks @janvorli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic helpers are reported with
MethodFlags.JitHelper. Events with this flag were ignored byPerfViewbefore this change.This fixes at least part of dotnet/runtime#88938.