Add EtlToSpeedScope UserCommand #1690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
its been a couple of months since this was looked at - just wanted to throw a quick bump here |
brianrob
reviewed
Oct 27, 2022
| { | ||
| throw new ApplicationException("Invalid number to lookup with."); | ||
| } | ||
| etlFile.CPUStacks().LookupWarmSymbols(warmSymbolLookupThreshold); |
There was a problem hiding this comment.
The call to CPUStacks() creates a new instance of Stacks unconditionally, meaning that the last line of this method will override this line if the caller specifies a process filter. You will want to save the StackSource in a local variable and then use it to generate the file.
There was a problem hiding this comment.
Correcting myself - the filter does stick. However, the stacks get calculated twice.
| } | ||
| etlFile.CPUStacks().LookupWarmSymbols(warmSymbolLookupThreshold); | ||
| } | ||
| SpeedScopeStackSourceWriter.WriteStackViewAsJson(etlFile.CPUStacks().StackSource, outputName); |
There was a problem hiding this comment.
lookupWarmSymbolsMinimumValue only has an impact if a process filter is specified. Presumably this should be used unconditionally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1688
Adds a UserCommand to convert etl files to .speedscope.json for data parsing. Added some parameters to filter the data down as well that are also used for other commands like process to filter on and warm symbol lookups.