Ignore errors instantiating symbol checksum algorithm. #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not need the checksum, so it doesn't make sense to crash. Some checksum methods will fail when FipsAlgorithmPolicy is enabled on your machine.
|
|
|
@beteitle, thanks for your contribution. In general, I want to keep these kinds of safeguards by default. Not having them can result in invalid/incorrect data in some cases. If you're running into cases where where the algorithms can't be executed, one option would be to have a flag, similiar to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore errors instantiating source checksum method during symbol source lookup. For many use cases, source checksum is a "nice to have", but not a requirement. Cryptography method instantiation may fail in certain cases. For example, if FipsAlgorithmPolicy is in place on your host machine, you are not allowed to instantiate MD5. Failing to checksum should not prevent source lookup workflow in my opinion (seems to work fine without it being performed for well behaving source server).