burette: add high-connection-count mode to network test#3862
Draft
benhillis wants to merge 2 commits into
Draft
Conversation
Add a --net-parallel flag to the burette network test that sets the number of parallel iperf3 streams (-P) for the TCP TX/RX subtests. It defaults to 1, preserving the existing single-stream behavior, and larger values drive many concurrent connections so the harness can measure optimizations that only appear in the high-connection-count regime. UDP stays single-stream. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new --net-parallel <N> CLI flag to the burette run --test network workflow to drive higher TCP connection counts by setting iperf3’s parallel stream count (-P N) for TCP TX/RX subtests, while keeping existing single-stream behavior by default.
Changes:
- Introduces
--net-parallelCLI argument inburette, defaulting to1. - Threads the new parameter into
NetworkTestand appends-P Nto TCP iperf3 client invocations whenN > 1. - Documents the new flag in the performance testing guide.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| petri/burette/src/tests/network.rs | Adds a parallel field to NetworkTest and passes -P N to iperf3 for TCP modes when parallel > 1. |
| petri/burette/src/main.rs | Adds --net-parallel CLI arg and wires it into NetworkTest construction. |
| Guide/src/dev_guide/tests/perf.md | Documents how to use --net-parallel for high-connection-count TCP testing. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--net-parallel <N>flag to the burettenetworktest. It sets the number of parallel iperf3 streams (-P) for the TCP TX/RX subtests. It defaults to1, preserving the existing single-stream behavior; larger values open many concurrent connections so the harness can exercise and measure optimizations that only appear in the high-connection-count regime. UDP stays single-stream.Metric names are unchanged, so a
burette comparebetween a baseline and a candidate run lines up as long as the same--net-parallelvalue is used for both.Details
petri/burette/src/main.rs: new--net-parallelCLI arg, threaded intoNetworkTest.petri/burette/src/tests/network.rs:parallelfield;-P Nadded to the TCP client invocations whenN > 1.Guide/src/dev_guide/tests/perf.md: documents the flag.Testing
cargo check -p burettecargo clippy --all-targets -p burettecargo doc --no-deps -p burettecargo xtask fmt --fix(burette has no unit tests.)