Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hypestv: support relaying serial ports to new windows #374

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jstarks
Copy link
Member

@jstarks jstarks commented Nov 21, 2024

Lift the console relay support from OpenVMM and use it to launch serial ports in separate windows. This replaces the need to separately use hvc for interactive serial ports.

To use:

serial 1 term

Also, add support for quit, and rename the output serial mode to log.

Lift the console relay support from OpenVMM and use it to launch serial
ports in separate windows. This replaces the need to separately use
`hvc` for interactive serial ports.

To use:

```
serial 1 term
```

Also, add support for `quit`, and rename the `output` serial mode to
`log`.
@jstarks jstarks requested review from a team as code owners November 21, 2024 20:06
@github-actions github-actions bot added the Guide label Nov 21, 2024

```
tdxvm [off]> serial 2 output
tdxvm [off]> serial 1 term
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another useful addition to this sort of tool: having a .hypestv_init file (a-la .gdbinit) which lets you configure a set of pre-baked commands to run when doing various kinds of vm development (e.g: depending on the guest that's running, or the vm sku, etc...).

the concern, of course, is that this opens up an avenue to "script" this dev tool...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that similar to this, we'd have the concept of a workspace that could be loaded or saved by name. And maybe if you name it the same as a VM, it gets loaded automatically or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like a .vmname file or something like that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I could probably get behind a scheme like auto-loading .hypestv-<vmname>.

@@ -275,8 +295,11 @@ pub async fn main(driver: DefaultDriver) -> anyhow::Result<()> {
.handle_command(cmd)
.await?;
}
InteractiveCommand::Quit => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I'm surprised this wasn't here in v0. how were you quitting before this? like, via ctrl-d?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ctrl-d.

@jstarks jstarks merged commit d5ffe88 into microsoft:main Nov 22, 2024
25 checks passed
@jstarks jstarks deleted the hypest-term branch November 22, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants