RFC: add optional disk table to the VMGS file #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disk table lists the disks that the host is allowed to offer, along with their encryption information (cipher + key). If the host offers a disk that is not in the list, fail to boot. This is designed to support unenlightened guests, and is opt in via environment variable. To use, prepopulate the VMGS file with the appropriate disk information, e.g.: ``` vmgstool disk-table -f vmgs.vmgs add --d 00000001-a4a3-11ef-9347-43f645bdedf8 -c xts-aes-256 -k key.bin ``` And in your OpenHCL configuration, ensure OPENHCL_USE_DISK_TABLE=1 is set. If using an encrypted disk, be sure to build openvmm-hcl with the `disk_crypt` feature.
daprilik
reviewed
Nov 21, 2024
| Remove { | ||
| /// The disk identifier | ||
| #[clap(long)] | ||
| disk: String, |
There was a problem hiding this comment.
shouldn't this be a Guid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disk table lists the disks that the host is allowed to offer, along with their encryption information (cipher + key). If the host offers a disk that is not in the list, fail to boot.
This is designed to support unenlightened guests, and is opt in via environment variable.
To use, prepopulate the VMGS file with the appropriate disk information, e.g.:
And in your OpenHCL configuration, ensure OPENHCL_USE_DISK_TABLE=1 is set.
If using an encrypted disk, be sure to build openvmm-hcl with the
disk_cryptfeature.