Added code to get the tsc time on HW-isolated VMs (TDX) - Issue 345. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckotamra
changed the title
chris-oo
requested changes
Nov 15, 2024
openhcl/openhcl_boot/src/main.rs
Outdated
| @@ -508,6 +511,18 @@ const fn zeroed<T: FromZeroes>() -> T { | |||
| unsafe { core::mem::MaybeUninit::<T>::zeroed().assume_init() } | |||
| } | |||
|
|
|||
| /// Get the tsc ref time for hw isolated vms in 100ns | |||
| #[allow(unused_variables)] | |||
| fn get_hw_tsc_time(isolation: IsolationType) -> u64 { | |||
There was a problem hiding this comment.
@smalis-msft do you know what it would take to do the same on SNP?
There was a problem hiding this comment.
Might be a better question for @sluck-msft? I haven't dug into the SNP docs nearly deep enough to know off the top of my head
There was a problem hiding this comment.
@adi-bhandari or @daaltobe maybe?
isolationType, SingleThreaded into minimal_rt
chris-oo
requested changes
Nov 19, 2024
into a match statement. Added UNSAFE comments around static mut variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, boot times are reported in the device tree only for non-hw-isolated vms by calling tsc refcount.
On TDX-based VMs, tsc ref time is calculated by: