Skip to content

enable default_boot_always_attempt for non-TL VMs (#2436) #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/2411
Choose a base branch
from
+18 −0
Open

enable default_boot_always_attempt for non-TL VMs (#2436) #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions openhcl/underhill_core/src/loader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,24 @@ pub fn write_uefi_config(
// OpenHCL pre-sets the MTRRs; tell the firmware
flags.set_mtrrs_initialized_at_load(true);

// Temporarily override the host provided default_boot_always_attempt
// value for non-Trusted Launch VMs until all hosts in Azure have been
// updated to provide the correct value.
//
// Trusted Launch is roughly equivalent to having secure boot and TPM
// enabled. For VMs that are not Trusted Launch, default boot is necessary
// because the VMGS is not swapped with the OS disk in Azure (and in any
// case on-prem), causing the VM to fail to boot after an OS swap.
//
// TODO: remove this (and petri workaround) once host changes are saturated
if isolated
&& !platform_config.general.secure_boot_enabled
&& !platform_config.general.tpm_enabled
{
tracing::info!("enabling default_boot_always_attempt");
flags.set_default_boot_always_attempt(true);
}

flags
});

Expand Down