wip: notes for handling restore on a node that does not support save restore (but openhcl does). #2371
Conversation
…restore (but openhcl does).
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
| // a restore on a host that does not support restore. | ||
| // | ||
| // This will: | ||
| // 1) Create a DMA client, be sure to say that we require persistent memory (even though save_restore_supported will actually be false). |
There was a problem hiding this comment.
This is good for handling the happy-path scenario but just wondering for a case where DMA fails to create persistent memory connections, do we fail here? If yes, maybe we need to think of a better fallback path as the host here doesn't support save-restore.
IMO we may allow it to proceed without saving the device state and when it live migrates off to a host that supports keepalive and private pool, we may need to allow the restore to happen successfully for such scenarios as well. Let me know your thoughts here as well.
2 participants
No description provided.