Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eigen to the latest #23717

Merged
merged 10 commits into from
Feb 18, 2025
Merged

Update Eigen to the latest #23717

merged 10 commits into from
Feb 18, 2025

Conversation

snnn
Copy link
Member

@snnn snnn commented Feb 16, 2025

Changes related to Eigen:

  1. Update eigen.cmake: Removed the use of cmake's fetchcontent_populate command as it is deprecated.
  2. Upgrade Eigen: Updated Eigen to the latest version to resolve a build issue. Without this update, the Android build would check for a Fortran compiler and report an error when running cmake config in Eigen's source directory.
  3. Add Eigen as a vcpkg port: Added Eigen as a vcpkg port since the official vcpkg repository version is outdated.
  4. Remove eigen_INCLUDE_DIRS variable: Removed the eigen_INCLUDE_DIRS cmake variable and replaced it with Eigen3::Eigen.

This change enables building ONNX Runtime(CPU EP only) as a vcpkg port. To do so, you also need to download the
ports/onnxruntime/vcpkg.json file from this PR: microsoft/vcpkg#36850

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

tools/ci_build/build.py Outdated Show resolved Hide resolved
tools/ci_build/github/android/build_aar_package.py Outdated Show resolved Hide resolved
@snnn snnn changed the title snnn/vcpkg eigen Update Eigen to the latest Feb 16, 2025
@snnn
Copy link
Member Author

snnn commented Feb 16, 2025

@ranjitshs , could you please help me update the patch file(cmake/patches/eigen/eigen-aix.patch) for AIX?

@ranjitshs
Copy link
Contributor

@ranjitshs , could you please help me update the patch file(cmake/patches/eigen/eigen-aix.patch) for AIX?

Sure. I will use this branch snnn/vcpkg_eigen and update the AIX patch , combining the exiting patch with the one provided in this.
Will raise PR once this is merged.

@snnn snnn merged commit 7c0c6fb into main Feb 18, 2025
96 of 98 checks passed
@snnn snnn deleted the snnn/vcpkg_eigen branch February 18, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants