-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Eigen to the latest #23717
Update Eigen to the latest #23717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
@ranjitshs , could you please help me update the patch file(cmake/patches/eigen/eigen-aix.patch) for AIX? |
Sure. I will use this branch snnn/vcpkg_eigen and update the AIX patch , combining the exiting patch with the one provided in this. |
Changes related to Eigen:
fetchcontent_populate
command as it is deprecated.eigen_INCLUDE_DIRS
cmake variable and replaced it withEigen3::Eigen
.This change enables building ONNX Runtime(CPU EP only) as a vcpkg port. To do so, you also need to download the
ports/onnxruntime/vcpkg.json file from this PR: microsoft/vcpkg#36850