Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN] Support negative steps for slice #22871

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WebNN] Support negative steps for slice #22871

wants to merge 5 commits into from
+52 −60

Conversation

shiyi9801
Copy link
Contributor

@shiyi9801 shiyi9801 commented Nov 18, 2024 •
edited
Loading

Slice with negative steps can be emulated by reverse+slice.

@shiyi9801
Copy link
Contributor Author

@Honry @fdwr PTAL, thanks :)

@shiyi9801
Copy link
Contributor Author

It suddenly occurred to me that maybe other negative steps can also be supported with reverse+slice... I'll figure it out tomorrow

@guschmue guschmue added the ep:WebNN WebNN execution provider label Nov 18, 2024
@shiyi9801 shiyi9801 changed the title [WebNN] Support slice steps == -1 [WebNN] Support negative steps for slice Nov 19, 2024
@shiyi9801
Copy link
Contributor Author

Updated. @Honry @fdwr PTAL, thanks!

Honry
Honry reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shiyi9801, LGTM % a nit.

onnxruntime/core/providers/webnn/builders/impl/slice_op_builder.cc Outdated Show resolved Hide resolved
onnxruntime/core/providers/webnn/builders/impl/slice_op_builder.cc Outdated Show resolved Hide resolved
Honry
Honry approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guschmue
guschmue previously approved these changes Nov 20, 2024
View reviewed changes
@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

fdwr
fdwr previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

onnxruntime/core/providers/webnn/builders/impl/slice_op_builder.cc Outdated Show resolved Hide resolved
onnxruntime/core/providers/webnn/builders/impl/slice_op_builder.cc Outdated Show resolved Hide resolved
@shiyi9801 shiyi9801 dismissed stale reviews from fdwr and guschmue via 4463ea6 November 21, 2024 02:55
fdwr
fdwr previously approved these changes Nov 21, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honry Honry Honry approved these changes

@guschmue guschmue guschmue left review comments

@fdwr fdwr fdwr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shiyi9801 @guschmue @fdwr @Honry