Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack plugin to support module workers #4742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RoccoC
Copy link

@RoccoC RoccoC commented Nov 5, 2024

This is a proposed fix for #4741 .

This PR updates the monaco-editor-webpack-plugin's getWorkerUrl to add support for module workers. The function now checks if import.meta is defined, and if so, uses import to load the worker script. Otherwise, it falls back to using importScripts for classic workers.

@RoccoC
Copy link
Author

RoccoC commented Nov 5, 2024

@microsoft-github-policy-service agree

@ginna-baker
Copy link

Bump -- could really use this for my team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants