CVM: Skip test cases not supporting TDX #3523
Open
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalca
force-pushed
the
kameroncarr/cvm-attestation
branch
from
9af0740
to
c45a4b3
Compare
trungams
reviewed
Nov 22, 2024
| @@ -61,6 +62,10 @@ def verify_azure_cvm_attestation_report( | |||
| result: TestResult, | |||
| variables: Dict[str, Any], | |||
| ) -> None: | |||
| if node.tools[Lscpu].get_cpu_type() != CpuType.AMD: | |||
There was a problem hiding this comment.
maybe move this condition check to the before_case function above, that's where the current environment check is happening
There was a problem hiding this comment.
Good catch :) Changed
Based on the test case description and steps, it looks like it is only designed to run on SEV-SNP, not on TDX or SGX SKUs. This matches test failure observations
kamalca
force-pushed
the
kameroncarr/cvm-attestation
branch
from
c45a4b3
to
224d8a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attestation report test cases only support AMD SEV-SNP so they should skip on other CPU types.
Also do not skip cpu_offline_channel_add test case as it is supported on all CPU types.