Few improvements to source installer #3249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 4, 2024 12:51
Signed-off-by: Konstantin Olshanov <[email protected]>
Signed-off-by: Konstantin Olshanov <[email protected]>
Signed-off-by: Konstantin Olshanov <[email protected]>
Add ability to enable/disable config entry or set it to 'm'. Signed-off-by: Konstantin Olshanov <[email protected]>
|
@microsoft-github-policy-service agree company="Cloud Linux" |
squirrelsc
reviewed
Apr 4, 2024
| @@ -264,6 +273,13 @@ def _build_code(self, node: Node, code_path: PurePath, kconfig_file: str) -> Non | |||
| sudo=True, | |||
| ) | |||
|
|
|||
| result = node.execute( | |||
There was a problem hiding this comment.
Make it optional, if the local_version is not specified, don't execute it.
squirrelsc
reviewed
Apr 4, 2024
| "EOF\n", | ||
| shell=True | ||
| ) | ||
| result.assert_exit_code() |
There was a problem hiding this comment.
Add error message to describe what happened.
squirrelsc
reviewed
Apr 4, 2024
| ) | ||
| result.assert_exit_code() | ||
|
|
||
| result = node.execute( |
There was a problem hiding this comment.
Can it be cat into the /etc/default/grub.d/99-lisa.cfg directly? So it doesn't need an extra command to copy.
|
@adityagesh @smit-gardhariya @SRIKKANTH Please help checking if there is regression on source installer. Thank you. |
|
@olshanov please fix check errors. You can refer to document to setup vscode or use nox to validate errors locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstdpackage required for kernel build. And Ubuntu 18.04 image lack ofcpiopackage;